Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: query only CLI, no tx commands, proposed gov proposal readme #105

Merged
merged 3 commits into from
Jan 12, 2022
Merged

docs: query only CLI, no tx commands, proposed gov proposal readme #105

merged 3 commits into from
Jan 12, 2022

Conversation

barriebyron
Copy link
Contributor

let's make this doc accurate, there is no CLI

Description

Docs must be accurate, so this PR reflects the "there is no CLI" situation

closes part of #71

Tasks

  • [ ]

References

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • [ x] Appropriate labels applied
  • [ x] Targeted PR against correct branch
  • [ x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • [x ] Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

cli readme
0db6659 
let's make this doc accurate, there is no CLI
@barriebyron barriebyron added the documentation Improvements or additions to documentation label Dec 2, 2021
@barriebyron barriebyron self-assigned this Dec 2, 2021
@barriebyron barriebyron mentioned this pull request Dec 2, 2021
Closed
4 tasks
jaybxyz
jaybxyz reviewed Dec 9, 2021
View reviewed changes
docs/How-To/cli/README.md Outdated Show resolved Hide resolved
docs/How-To/cli/README.md Outdated Show resolved Hide resolved
@barriebyron barriebyron changed the title docs: the "there is no CLI" here's the proposed gov proposal readme docs: query only CLI, no tx commands, proposed gov proposal readme Dec 10, 2021
@barriebyron
Copy link
Contributor Author

hi @kogisin thanks for your feedback. This time I made your requested changes. In future, please do jump in and make any changes you require. It's better together. :)

jaybxyz
jaybxyz approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@jaybxyz jaybxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaybxyz jaybxyz merged commit c1646df into main Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaybxyz jaybxyz jaybxyz approved these changes

Assignees

@barriebyron barriebyron

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barriebyron @jaybxyz @dongsam